Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump styled-components from 5.3.11 to 6.1.11 #43057

Merged
merged 9 commits into from
Jul 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 14, 2024

Bumps styled-components from 5.3.11 to 6.1.11.

Release notes

Sourced from styled-components's releases.

v6.1.11

What's Changed

Full Changelog: styled-components/styled-components@v6.1.10...v6.1.11

v6.1.10

What's Changed

New Contributors

Full Changelog: styled-components/styled-components@v6.1.9...v6.1.10

v6.1.9

What's Changed

New Contributors

Full Changelog: styled-components/styled-components@v6.1.8...v6.1.9

v6.1.8

Revert adding peerDependencies from v6.1.7; apparently some package managers have differing behaviors around peerDependenciesMeta[package].optional which is causing issues. Will revisit at a later date if possible.

Full Changelog: styled-components/styled-components@v6.1.7...v6.1.8

v6.1.7

What's Changed

  • chore: add all missing peer dependency statements by @​quantizor in styled-components/styled-components#4243

    NOTE: this change may cause some installed dependency duplication until this NPM bug is addressed but yarn and pnpm have correct behavior. Bun also has a similar bug.

    Overall these changes ensure that styled-components is specifying a known working version of all utilized libraries, while instructing the client package manager that higher semver-compliant versions are permissible and should work, assuming the relevant libraries are compliant in practice.

Full Changelog: styled-components/styled-components@v6.1.6...v6.1.7

v6.1.6

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file no-changelog Indicates that a PR does not require a changelog entry ui labels Jun 14, 2024
@dependabot dependabot bot requested review from avatus, bl-nero, kimlisa and rudream June 14, 2024 21:11
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/styled-components-6.1.11 branch 8 times, most recently from 6a64140 to b1fc463 Compare June 21, 2024 17:18
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/styled-components-6.1.11 branch 3 times, most recently from a8d0356 to 7756ea0 Compare July 3, 2024 15:35
@bl-nero
Copy link
Contributor

bl-nero commented Jul 4, 2024

Folks, I'm taking it and resolving problems right now.

@bl-nero bl-nero force-pushed the dependabot/npm_and_yarn/styled-components-6.1.11 branch from 7756ea0 to 3016ca8 Compare July 4, 2024 17:30
@bl-nero
Copy link
Contributor

bl-nero commented Jul 4, 2024

I pushed a bunch of changes, there's also an Enterprise draft PR, but I'm still wrestling with three unit tests.

dependabot bot and others added 5 commits July 9, 2024 12:49
Bumps [styled-components](https://github.com/styled-components/styled-components) from 5.3.11 to 6.1.11.
- [Release notes](https://github.com/styled-components/styled-components/releases)
- [Commits](styled-components/styled-components@v5.3.11...v6.1.11)

---
updated-dependencies:
- dependency-name: styled-components
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@bl-nero bl-nero force-pushed the dependabot/npm_and_yarn/styled-components-6.1.11 branch from 3016ca8 to 64db930 Compare July 9, 2024 11:24
@bl-nero
Copy link
Contributor

bl-nero commented Jul 9, 2024

Notes:

  • It's easiest to review this PR one commit at a time.
  • There were two major issues that required fixing: fixing the syntax of pseudoclass and pseudoelement selectors, and forcing the old (5.x) logic of passing props down the wrapper chain. Embracing the new way would require too many changes.
  • Most of the snapshot changes are meaningless whitespace. A couple of rare exceptions are changed autogenerated classnames.
  • I verified the new UI by visually inspecting selected parts of the UI, as well as making sure that the web console doesn't log any additional errors.

Copy link
Contributor

@gzdunek gzdunek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏
I quickly tested Connect and Web UI, I didn't see any regressions.

@@ -28,6 +29,8 @@ import cfg from 'teleport/config';

import { Theme } from 'gen-proto-ts/teleport/userpreferences/v1/theme_pb';

import isPropValid from '@emotion/is-prop-valid';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to declare this dependency in design/package.json.

@bl-nero bl-nero added this pull request to the merge queue Jul 12, 2024
@bl-nero bl-nero removed this pull request from the merge queue due to a manual request Jul 12, 2024
@bl-nero bl-nero enabled auto-merge July 12, 2024 10:15
@gzdunek
Copy link
Contributor

gzdunek commented Jul 12, 2024

@bl-nero did you want to remove the new lines at the end of package.json files?
image
Hmm, I guess it's just my editor. Damn.

@bl-nero bl-nero disabled auto-merge July 12, 2024 10:21
@bl-nero bl-nero enabled auto-merge July 12, 2024 10:35
@bl-nero bl-nero added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit 4947c0d Jul 12, 2024
40 checks passed
@bl-nero bl-nero deleted the dependabot/npm_and_yarn/styled-components-6.1.11 branch July 12, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog Indicates that a PR does not require a changelog entry ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants